search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Update deps for knative release 0.13 #319

Closed k4leung4 closed 4 years ago

k4leung4 commented 4 years ago

Fixes #

Proposed Changes

*

Release Note

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k4leung4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [k4leung4] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
houshengbo commented 4 years ago

This is the error launching the operator pod.

{"level":"fatal","ts":"2020-03-03T16:45:32.485Z","logger":"serving_operator","caller":"sharedmain/main.go:189","msg":"Error loading leader election configuration: resourceLock: invalid value \"\": valid values are \"leases\",\"configmaps\",\"endpoints\"","commit":"ee018e8","stacktrace":"knative.dev/serving-operator/vendor/knative.dev/pkg/injection/sharedmain.MainWithConfig\n\tknative.dev/serving-operator/vendor/knative.dev/pkg/injection/sharedmain/main.go:189\nmain.main\n\tknative.dev/serving-operator/cmd/manager/main.go:34\nruntime.main\n\truntime/proc.go:203"}
knative-prow-robot commented 4 years ago

@k4leung4: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k4leung4 commented 4 years ago

/close

knative-prow-robot commented 4 years ago

@k4leung4: Closed this PR.

In response to [this](https://github.com/knative/serving-operator/pull/319#issuecomment-595344547): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.