search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Remove includeOutboundIPRanges config from minikube #323

Closed nak3 closed 4 years ago

nak3 commented 4 years ago

Proposed Changes

By https://github.com/knative/serving/pull/6597/ istio.sidecar.includeOutboundIPRanges is obsoleted.

This patch removes the config from minikube sample operator.

/lint

Release Note

NONE
nak3 commented 4 years ago

I'm wondering if entire minikube-operator-example, but I just removed the config in this PR.

k4leung4 commented 4 years ago

@trshafer @jcrossley3 can either of you remind me whats the purpose of this minikube-operator-example and how do we ensure that it is tested and up to date?

k4leung4 commented 4 years ago

/cc trshafer jcrossley3 /assign trshafer jcrossley3

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jcrossley3 commented 4 years ago

@k4leung4 imo, the example doesn't belong in this repo -- it belongs in its own -- so I believe its existence in here is only temporary.