search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Remove empty leader election config #326

Closed pmorie closed 4 years ago

pmorie commented 4 years ago

321 accidentally added an empty configmap, which we can't distribute via operatorhub currently. This PR removes it; when the configmap does not exist, leader election is disabled by default.

NONE
pmorie commented 4 years ago

/retest

looks like istio installation flaked

k4leung4 commented 4 years ago

/retest

k4leung4 commented 4 years ago

/retest

houshengbo commented 4 years ago

/rebase

k4leung4 commented 4 years ago

/retest

k4leung4 commented 4 years ago

/approve /lgtm

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k4leung4, pmorie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [k4leung4] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment