search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

`KnativeServing` api files live in wrong directory #336

Closed aliok closed 4 years ago

aliok commented 4 years ago

Problem KnativeServing api files live in wrong directory.

Its group is operator.knative.dev but the api files are in pkg/apis/serving/... They should be in pkg/apis/operator/..

This is a better practice and some tools like operator-sdk is expecting that kind of consistent directory tree when generating some metadata. See https://github.com/operator-framework/operator-sdk/pull/2511#issuecomment-595667664

Persona: Contributors

Exit Criteria Have the directory name changed and have the tests passing.

Time Estimate (optional): 0.5 developer-day

Additional context (optional) None

aliok commented 4 years ago

/close

In the new operator I see this is fixed. https://github.com/knative-sandbox/operator

knative-prow-robot commented 4 years ago

@aliok: Closing this issue.

In response to [this](https://github.com/knative/serving-operator/issues/336#issuecomment-611983486): >/close > >In the new operator I see this is fixed. https://github.com/knative-sandbox/operator Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.