search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Bump to manifestival 0.4.0 #338

Closed jcrossley3 closed 4 years ago

jcrossley3 commented 4 years ago

Fixes a pretty gnarly bug where transformers using Scheme.Convert don't work.

This was exposed by #337

k4leung4 commented 4 years ago

/retest

chizhg commented 4 years ago

@jcrossley3 can you type @googlebot I consent. here? This seems to be a googlebot's problem.

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, jcrossley3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [houshengbo,jcrossley3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment