search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Remove the deprecated short name from README #346

Closed rokrokss closed 4 years ago

rokrokss commented 4 years ago

Proposed Changes

Release Note

Remove the deprecated short name from README.
googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

knative-prow-robot commented 4 years ago

Welcome @q0115643! It looks like this is your first PR to knative/serving-operator 🎉

knative-prow-robot commented 4 years ago

Hi @q0115643. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 4 years ago

@q0115643: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/knative/serving-operator/pull/346#issuecomment-597982906): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rokrokss commented 4 years ago

/check-cla

rokrokss commented 4 years ago

This was my first PR to google opensource so I signed CLA just before writing this comment. I think ok-to-test is needed to retest on cla.

houshengbo commented 4 years ago

/ok-to-test

houshengbo commented 4 years ago

Thank @q0115643 for the contribute! /lgtm /approve

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, q0115643

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

rokrokss commented 4 years ago

@houshengbo sorry for the inconvenience, my profile in the commit was a bit messed up so I force-pushed a new commit with same change.

k4leung4 commented 4 years ago

/lgtm