search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Update yaml #355

Closed houshengbo closed 4 years ago

houshengbo commented 4 years ago

Fixes #

Proposed Changes

*

Release Note

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k4leung4 commented 4 years ago

can we write simple script for updating the yaml file? as it is effectively a big blob, its hard to review, and would be nice if people can reproduce the yaml update.

for the version, what is the format for the version field do we want? feels like we flip flop between the knative version and a date-hash string?

knative-prow-robot commented 4 years ago

@houshengbo: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-operator-upgrade-tests cd0a1ba8f01926d4033daff75d70d15386b88ed7 link /test pull-knative-serving-operator-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).