search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

OLM metadata for 0.13.1 #360

Closed aliok closed 4 years ago

aliok commented 4 years ago

Fixes #

Proposed Changes

Release Note

NONE
aliok commented 4 years ago

/hold

Hold until https://github.com/operator-framework/community-operators/pull/1338 is merged

k4leung4 commented 4 years ago

do we want to wait for 0.13.1?

it has this fix, https://github.com/knative/pkg/commit/122514b865f268704598561649e61bfb4bc41885

aliok commented 4 years ago

do we want to wait for 0.13.1?

Yeah, let's wait until then.

houshengbo commented 4 years ago

@k4leung4 operator 0.13.0 has already included knative/pkg@122514b

aliok commented 4 years ago

/unhold

https://github.com/operator-framework/community-operators/pull/1338 is merged

aliok commented 4 years ago

cc @houshengbo

aliok commented 4 years ago

/lgtm

knative-prow-robot commented 4 years ago

@aliok: you cannot LGTM your own PR.

In response to [this](https://github.com/knative/serving-operator/pull/360#issuecomment-607705414): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
houshengbo commented 4 years ago

/lgtm @aliok PLZ be aware that we are targeting to release one operator for coming release-0.15.

houshengbo commented 4 years ago

/hold cancel

houshengbo commented 4 years ago

/approve

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [aliok,houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment