search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Update the manifest to the latest nightly build #369

Closed houshengbo closed 4 years ago

houshengbo commented 4 years ago

Fixes #

Proposed Changes

*

Release Note

k4leung4 commented 4 years ago

How often do we have to update the manifest to the latest nightly? Should we investigate into automation if this should be done frequently?

houshengbo commented 4 years ago

@k4leung4 I plan to do it on a weekly basis, but there are several issues:

  1. Inconsistency of labels used in one nightly built yaml: If we download the latest serving yaml here https://storage.googleapis.com/knative-nightly/serving/latest/serving.yaml. I see the deployment name: networking-istio has the label serving.knative.dev/release: "v20200316-516fac9" , but the deployment name: autoscaler-hpa has the label serving.knative.dev/release: "v20200319-2f826455d" Why do we have two different labels? If we do it automatically, how to get the version number?

  2. How to change the version number in version.go, if we do the update automatically?

k4leung4 commented 4 years ago

  1. the release labels are different because net-istio is built from knative.dev/net-istio and vendored, https://github.com/knative/serving/pull/7266/files

  2. we only use release versions for releases right? so maybe have a daily job that updates with the nightly build. for releases, we manually do update with the release build, cut the release branch, and the daily job will update it back to the nightly build?

houshengbo commented 4 years ago

The issue is with the unit tests TestManifestVersionSame. If the version does not match the version number in manifest, they fail.

k4leung4 commented 4 years ago

/approve /lgtm

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, k4leung4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [houshengbo,k4leung4] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment