Install from the manifest in a strict(er) order.

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/

Apache License 2.0

39 stars 48 forks source link

Install from the manifest in a strict(er) order. #374

Closed Cynocracy closed 4 years ago

Cynocracy commented 4 years ago

This order, Roles -> RoleBindings -> The Rest, prevents the operand from needing to structure their manifest such that this ordering exists, while allowing the Operator to use the bootstrapping mechanism described in https://github.com/knative/serving-operator/pull/291 to 'escalate' itself into management of the Knative Serving installation without a *** clusterrole.

Proposed Changes

Install roles, then rolebindings, then the remainder of the manifest.

Release Note

NONE

Cynocracy commented 4 years ago

Will probably need to find a different assignee :(

k4leung4 commented 4 years ago

/lgtm

Cynocracy commented 4 years ago

Thanks for the review :)

jcrossley3 commented 4 years ago

/lgtm /approve

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynocracy, jcrossley3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [jcrossley3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment