search

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/
Apache License 2.0
39 stars 45 forks source link

Pass config from main to the controller. #407

Closed markusthoemmes closed 4 years ago

markusthoemmes commented 4 years ago

Proposed Changes

To align with https://github.com/knative-sandbox/operator/pull/21 and to be able to use this controller as a "library" (to compile multiple operators into one binary), this moves the flag definition to the main.go file and passes the built config through.

Release Note

NONE

/assign @jcrossley3 @houshengbo

aliok commented 4 years ago

/approve /lgtm

Makes a lot of sense. I know we're not really going to use this operator's pkg as a library, but aligning with the new operator is nice.

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/master/OWNERS)~~ [aliok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment