Closed scott-wong closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Hi @scott-wong. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Welcome @scott-wong! It looks like this is your first PR to knative/serving-operator 🎉
@googlebot I signed it!
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: markusthoemmes, scott-wong
To complete the pull request process, please assign trshafer
You can assign the PR to them by writing /assign @trshafer
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/ok-to-test
Proposed Changes
Release Note