Fix the retry issue with deployment verification (#387)

knative / serving-operator

DEPRECATED: Development continues in https://github.com/knative/operator/

Apache License 2.0

39 stars 48 forks source link

Fix the retry issue with deployment verification (#387) #414

Closed houshengbo closed 4 years ago

houshengbo commented 4 years ago

The retry mechanism in the test cases ONLY get sand verifies the resources ONCE, since it always returns an error in the retry logic. To make the retry really work, we need to return nil for next retry before timeout.

Proposed Changes

This PR is a cherry-pick of acb5e5d23b01d8afd82a4f4c4f0c73bc9847f90c, resolving the issue of ONLY verifying the resource ONCE.

Release Note

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving-operator/blob/release-0.13/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

markusthoemmes commented 4 years ago

Can you please provide a description of which issue is fixed here? I have no clue what the "retry issue with deployment verification" is to be honest.

houshengbo commented 4 years ago

@markusthoemmes I had this fix in release 0.14. It was my fault of only trying ONLY ONCE to verify the resources of the knative deployments. I suspected the failure of https://github.com/knative/serving-operator/pull/413, was introduced by the defected retrying.

houshengbo commented 4 years ago

Close this PR, because this repo is deprecated.