knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.54k stars 1.15k forks source link

buildpack-function sample doesn't build #1445

Closed imjasonh closed 5 years ago

imjasonh commented 6 years ago

Expected Behavior

Running steps in https://github.com/knative/serving/tree/master/sample/buildpack-function#running produces a deployment that builds successfully and becomes ready.

Actual Behavior

The build fails. In the logs for the build-step-build init container in the build pod, logs indicate:

 Error: invalid version 

Failed to compile droplet: Failed to run all supply scripts: exit status 1
2018/07/02 01:56:06 Error: failed to build: exit status 223

There doesn't appear to be more information than this.

Steps to Reproduce the Problem

  1. Follow instructions in https://github.com/knative/serving/tree/master/sample/buildpack-function#running

Additional Info

buildpack-app seems to build and become ready without any trouble. The source for buildpack-function is at https://github.com/projectriff-samples/node-square

This might be a good candidate to graduate to an automatic e2e test, so that future sample breakages are detected automatically.

sclevine commented 6 years ago

@scothis the error seems to be coming from the function invoker buildpack. Any thoughts?

scothis commented 6 years ago

I just tried the buildpack-function sample, it builds and runs clean for me. The function and buildpack have not changed in two months. My best guess is that there was a transient glitch with the feed n uses to install node.

mattmoor commented 5 years ago

the samples moved, so this is obsolete