search

knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.48k stars 1.14k forks source link

test/conformance/api/v1beta1.TestDomainMapping is being skipped in Prow but passing in Kind #15203

Open izabelacg opened 2 months ago

izabelacg commented 2 months ago

Question

Can we consider removing the snippet that drops the enable-alpha and enable-beta flags from e2e-tests.sh script for gateway-api testing?

Context

Currently, tests such as test/conformance/api/v1beta1.TestDomainMapping and a few others tests related to alpha and beta features are currently being skipped in Prow, as observed in gateway-api-contour and gateway-api-istio. This skipping appears to be due to the removal of enable-alpha and enable-beta flags for gateway-api in the e2e-tests.sh script here:

https://github.com/knative/serving/blob/40088e3e93fa1d99b9e97421416baf8fe144dca0/test/e2e-tests.sh#L45-L49

However, some tests that run in Kind (GitHub Actions) don't use the e2e-tests.sh script to run the tests and explicitly set the above-mentioned flags, resulting in successful test execution.

Important to note that in Kind, we only run end-to-end tests, not conformance tests. However, some alpha and beta features are successfully tested in Kind. The specific test mentioned in this issue, test/conformance/api/v1beta1.TestDomainMapping, is not run in Kind since it is a conformance test. Nevertheless, it was tested locally and passed.

https://github.com/knative/serving/blob/40088e3e93fa1d99b9e97421416baf8fe144dca0/.github/workflows/kind-e2e.yaml#L212-L221

Test PR with tests passing in Kind: https://github.com/knative/serving/pull/15202

skonto commented 2 months ago

Hi @izabelacg, @dprotaso removed the flags here: https://github.com/knative/serving/pull/14296 maybe the idea was to get all basic tests pass first on prow? Btw I am ok to discover failing stuff upfront.