search

knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.54k stars 1.15k forks source link

Allow ipv6 address for sslip.io in default-domain Job #15328

Closed tcnghia closed 3 months ago

tcnghia commented 3 months ago

Proposed Changes

Release Note

Allow ipv6 address for sslip.io in default-domain Job
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.74%. Comparing base (2e5d17e) to head (1f32aff). Report is 4 commits behind head on main.

Files Patch % Lines
cmd/default-domain/main.go 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15328 +/- ## ========================================== - Coverage 84.75% 84.74% -0.01% ========================================== Files 218 218 Lines 13504 13508 +4 ========================================== + Hits 11445 11448 +3 + Misses 1692 1690 -2 - Partials 367 370 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

skonto commented 3 months ago

It runs ok for ip4, run it locally. /lgtm /hold for @dprotaso

dprotaso commented 3 months ago

/lgtm /approve /hold cancel

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving/blob/main/OWNERS)~~ [dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment