knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.46k stars 1.14k forks source link

re-enable failng contour/gateway api tests #15334

Closed dprotaso closed 1 week ago

dprotaso commented 1 week ago

Contour has a new release out (1.29) which fixes this issue

Fixes: https://github.com/knative-extensions/net-gateway-api/issues/711 Fixes: https://github.com/knative/serving/issues/15092 Fixes: https://github.com/knative/serving/issues/15089

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.72%. Comparing base (e56319d) to head (2b1d95f). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15334 +/- ## ========================================== - Coverage 84.80% 84.72% -0.08% ========================================== Files 218 218 Lines 13508 13508 ========================================== - Hits 11455 11445 -10 - Misses 1687 1692 +5 - Partials 366 371 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 1 week ago

/test ?

knative-prow[bot] commented 1 week ago

@dprotaso: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/knative/serving/pull/15334#issuecomment-2177145286): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dprotaso commented 1 week ago

/test gateway-api-latest /test gateway-api-latest-and-contour

skonto commented 1 week ago

/lgtm /approve

knative-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving/blob/main/OWNERS)~~ [dprotaso,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment