search

knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.46k stars 1.14k forks source link

[wip] [test-only] Rand fix #15354

Closed skonto closed 4 days ago

skonto commented 5 days ago

Fixes #

Proposed Changes

Release Note

knative-prow[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving/blob/main/OWNERS)~~ [skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.64%. Comparing base (1dff15d) to head (4cbf149).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15354 +/- ## ========================================== + Coverage 84.59% 84.64% +0.04% ========================================== Files 219 219 Lines 13584 13584 ========================================== + Hits 11492 11498 +6 + Misses 1726 1721 -5 + Partials 366 365 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 5 days ago

@skonto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build-tests_serving_main 4cbf14908fe8774cadf1e70e2f200e77c609fea9 link true /test build-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
skonto commented 5 days ago

All tests pass I will create a PR.

dprotaso commented 4 days ago

thanks for verifying - update deps PR merged in