search

knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.57k stars 1.16k forks source link

[wip] attempt pod addressability for the autoscaler #15388

Open dprotaso opened 4 months ago

dprotaso commented 4 months ago

Changes

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving/blob/main/OWNERS)~~ [dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprotaso commented 4 months ago

/test all

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.56%. Comparing base (2156812) to head (190c73c). Report is 107 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15388 +/- ## ========================================== - Coverage 84.58% 84.56% -0.02% ========================================== Files 219 219 Lines 13587 13587 ========================================== - Hits 11492 11490 -2 - Misses 1726 1728 +2 Partials 369 369 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 4 months ago

/test all

dprotaso commented 4 months ago

/test ?

knative-prow[bot] commented 4 months ago

@dprotaso: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/knative/serving/pull/15388#issuecomment-2221204316): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dprotaso commented 4 months ago

/test istio-latest-mesh /test istio-latest-mesh-short /test istio-latest-mesh-tls

knative-prow[bot] commented 4 months ago

@dprotaso: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
istio-latest-mesh-tls_serving_main 190c73cd40e0777ddade5273cff2612dcbe3e24e link false /test istio-latest-mesh-tls
istio-latest-mesh-short_serving_main 190c73cd40e0777ddade5273cff2612dcbe3e24e link false /test istio-latest-mesh-short
istio-latest-mesh_serving_main 190c73cd40e0777ddade5273cff2612dcbe3e24e link false /test istio-latest-mesh

Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
skonto commented 4 months ago

Failed to probe clusterIP None:80 err=error roundtripping http://None:80/healthz: dial tcp: lookup None on 10.26.112.10:53: no such host

dprotaso commented 4 months ago

Yeah passthrough isn't enabled on the tests.

One thing though - I think we could do a headless service and do probing using the hostname instead of the cluster IP.

I'll do a separate PR for that

github-actions[bot] commented 1 month ago

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.