knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.57k stars 1.16k forks source link

[Automated] Update net-istio nightly #15393

Closed knative-automation closed 4 months ago

knative-automation commented 4 months ago

/assign @knative/serving-writers /cc @knative/serving-writers

Produced via:

for x in net-istio.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-istio/latest/$x > ${GITHUB_WORKSPACE}/./third_party/istio-latest/$x
done

Details:

bumping knative.dev/net-istio 8aa5561...be4f06e:
  > be4f06e Revert https://github.com/knative-extensions/net-istio/pull/1085 (# 1344)
knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/serving/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.58%. Comparing base (44a5d78) to head (59a2786). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15393 +/- ## ========================================== + Coverage 84.55% 84.58% +0.03% ========================================== Files 219 219 Lines 13587 13587 ========================================== + Hits 11488 11493 +5 + Misses 1729 1726 -3 + Partials 370 368 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 4 months ago

cc @ReToCode looks like istio tls tests are broken? but I thought they were skipped

ReToCode commented 4 months ago

looks like istio tls tests are broken? but I thought they were skipped

Only the system-internal-tls ones are skipped. This is probably related to the revert. I'll take a look 👀