search

knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.57k stars 1.16k forks source link

Add support for hostipc, hostpid and hostnetwork #15414

Closed skonto closed 3 months ago

skonto commented 3 months ago

Fixes #12830

Proposed Changes

Release Note

Allow hostPID, hostNetwork and HostIPC to be set for a Knative Service (feature flags: kubernetes.podspec-hostpid, kubernetes.podspec-hostnetwrok, kubernetes.podspec-hostipc). All features are disabled by default.
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.57%. Comparing base (7d318cd) to head (e9dddaa). Report is 18 commits behind head on main.

Files Patch % Lines
pkg/apis/serving/fieldmask.go 0.00% 3 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15414 +/- ## ========================================== - Coverage 84.60% 84.57% -0.04% ========================================== Files 219 219 Lines 13587 13597 +10 ========================================== + Hits 11495 11499 +4 - Misses 1725 1728 +3 - Partials 367 370 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

skonto commented 3 months ago

TestSubrouteLocalSTS/shortest failed with Contour. cc @dprotaso

skonto commented 3 months ago

@dprotaso gentle ping.

dprotaso commented 3 months ago

/lgtm

dprotaso commented 3 months ago

/approve

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving/blob/main/OWNERS)~~ [ReToCode,dprotaso,skonto] - ~~[pkg/apis/OWNERS](https://github.com/knative/serving/blob/main/pkg/apis/OWNERS)~~ [dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
skonto commented 3 months ago

/unhold