search

knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.57k stars 1.16k forks source link

Clean up #15415

Closed skonto closed 3 months ago

skonto commented 3 months ago

Proposed Changes

vs old ones

controller.knative.dev.serving.pkg.reconciler.configuration.reconciler.00-of-01           controller-6878cd7fdd-8hmdx_3a651de5-c1b8-459b-b822-52551dd5df9f              20s
controller.knative.dev.serving.pkg.reconciler.gc.reconciler.00-of-01                      controller-6878cd7fdd-8hmdx_520566d5-0dc4-40ad-9c55-3cbcf8b7d241              20s
controller.knative.dev.serving.pkg.reconciler.labeler.reconciler.00-of-01                 controller-6878cd7fdd-8hmdx_c5529a8f-9036-4880-b8c6-ba17aa765633              20s
controller.knative.dev.serving.pkg.reconciler.nscert.reconciler.00-of-01                  controller-6878cd7fdd-8hmdx_4021ae51-e8d4-4d53-8bb6-c25baa4d33b8              20s
controller.knative.dev.serving.pkg.reconciler.revision.reconciler.00-of-01                controller-6878cd7fdd-8hmdx_f44c54d0-93cb-4e89-a0a5-39b0b25bb195              20s
controller.knative.dev.serving.pkg.reconciler.route.reconciler.00-of-01                   controller-6878cd7fdd-8hmdx_7954f43f-0353-4969-8f86-526d2e2be7c4              20s
controller.knative.dev.serving.pkg.reconciler.serverlessservice.reconciler.00-of-01       controller-6878cd7fdd-8hmdx_8861c1e8-c601-42c9-a87f-2763bde459fe              20s
controller.knative.dev.serving.pkg.reconciler.service.reconciler.00-of-01                 controller-6878cd7fdd-8hmdx_14021aca-46f2-4116-863c-4b4ab7ed433e              20s
domainmapping-webhook.defaultingwebhook.00-of-01                                          domainmapping-webhook-7877fd9dc8-tjhzz_281f9346-af2e-4d8a-a31d-a8c4d05045c4   11s
domainmapping-webhook.validationwebhook.00-of-01                                          domainmapping-webhook-7877fd9dc8-tjhzz_c5c786d4-e53f-4756-b80d-cdc3b12d9fcf   11s
domainmapping-webhook.webhookcertificates.00-of-01                                        domainmapping-webhook-7877fd9dc8-tjhzz_a4df0a82-bcfc-4a4b-b92c-9d7ac4fb371b   11s
domainmapping.knative.dev.serving.pkg.reconciler.domainmapping.reconciler.00-of-01        domain-mapping-7fd665586-28kmj_acdb43df-ebd6-4723-b768-87881492bf54           3s

net-certmanager leases:

net-certmanager-controller.knative.dev.net-certmanager.pkg.reconciler.certificate.reconciler.00-of-01   net-certmanager-controller-66bd995955-cwxtz_246e43c5-53b7-44d2-9d69-0e7fb52d3d47   75s
net-certmanager-webhook.configmapwebhook.00-of-01                                                       net-certmanager-webhook-68657dd744-7twft_d9775f32-c0bc-4681-bf41-84cc307aff3f      68s
net-certmanager-webhook.webhookcertificates.00-of-01                                                    net-certmanager-webhook-68657dd744-7twft_ad920135-4ff7-401d-8e15-dddf24588210      68s

There are more leases we never deleted as we made changes across releases (maybe for a future PR):

controller.knative.dev.networking.pkg.certificates.reconciler.reconciler.00-of-01
controller.knative.dev.control-protocol.pkg.certificates.reconciler.reconciler.00-of-01   controller-6878cd7fdd-8hmdx_57c4aee6-0fcc-4238-9b4a-7061c39d06bd              20s
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.52%. Comparing base (7d318cd) to head (99c6f3a). Report is 5 commits behind head on main.

Files Patch % Lines
pkg/cleanup/cmd/cleanup/cleanup.go 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15415 +/- ## ========================================== - Coverage 84.60% 84.52% -0.08% ========================================== Files 219 219 Lines 13587 13593 +6 ========================================== - Hits 11495 11490 -5 - Misses 1725 1734 +9 - Partials 367 369 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 3 months ago

/lgtm /approve /cherry-pick release-1.15

knative-prow-robot commented 3 months ago

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to [this](https://github.com/knative/serving/pull/15415#issuecomment-2255961458): >/lgtm >/approve >/cherry-pick release-1.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving/blob/main/OWNERS)~~ [dprotaso,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprotaso commented 3 months ago

Can you make a PR to delete these ones and I'll cherry pick that back too

controller.knative.dev.networking.pkg.certificates.reconciler.reconciler.00-of-01 controller.knative.dev.control-protocol.pkg.certificates.reconciler.reconciler.00-of-01

What controller had this lease controller.knative.dev.networking.pkg.certificates.reconciler.reconciler.00-of-01 ?

knative-prow-robot commented 3 months ago

@dprotaso: new pull request created: #15418

In response to [this](https://github.com/knative/serving/pull/15415#issuecomment-2255961458): >/lgtm >/approve >/cherry-pick release-1.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
skonto commented 3 months ago

Can you make a PR to delete these ones and I'll cherry pick that back too

What controller had this lease controller.knative.dev.networking.pkg.certificates.reconciler.reconciler.00-of-01 ?

Sure I need to take a look. I just noticed during some testing.

skonto commented 3 months ago

@dprotaso

controller.knative.dev.networking.pkg.certificates.reconciler.reconciler.00-of-01 was added in 1.11 see https://github.com/knative/networking/pull/802. With 1.11 controller.knative.dev.control-protocol.pkg.certificates.reconciler.reconciler.00-of-01 became redundant. Later on controller.knative.dev.networking.pkg.certificates.reconciler.reconciler.00-of-01 was also removed https://github.com/knative/networking/commit/060ef7acae5d713cb07c9948cc8d2e3c50be214a With 1.15 and when internal encryption is on we get controller.knative.dev.serving.pkg.reconciler.certificate.reconciler.00-of-01.

This happened due to the intermediate steps taken to move to current internal encryption implementation cc @ReToCode in case I miss anything.

I will create a PR to update the cleanup job for those two leases. So anyone running the job in 1.15 will have a cleaned state. I am not sure if Knative operator cleans up those resources since they are not part of the manifest but I guess the clean up job is for 1.15+.