knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.57k stars 1.16k forks source link

Do not run TestTLSCertificateRotation in parallel with other tests #15417

Closed mgencur closed 3 months ago

mgencur commented 3 months ago

This test deletes the serving-tests/serving-certs during the test run. This might break the other test TestSystemInternalTLS because it waits for certain log lines to appear in the service pods. Deleting the serving-certs secret causes the application pods to be deleted so that the new cert can be mounted. And waiting for given log lines then fails because the pod no longer exists:

system_internal_tls_test.go:110: TLS not used on requests to queue-proxy: pods
"system-internal-tls-wgvxqtyx-00001-deployment-6fdc4c8c7d-4ll8q" not found

Fixes #

Proposed Changes

*

Release Note

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.60%. Comparing base (7643497) to head (f4d1070).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15417 +/- ## ========================================== - Coverage 84.62% 84.60% -0.03% ========================================== Files 219 219 Lines 13587 13587 ========================================== - Hits 11498 11495 -3 - Misses 1722 1726 +4 + Partials 367 366 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving/blob/main/OWNERS)~~ [ReToCode] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment