search

knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.57k stars 1.16k forks source link

Clean up old certificate leases #15420

Closed skonto closed 3 months ago

skonto commented 3 months ago

Proposed Changes

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@8ab2768). Learn more about missing BASE report.

Files Patch % Lines
pkg/cleanup/cmd/cleanup/cleanup.go 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15420 +/- ## ======================================= Coverage ? 84.53% ======================================= Files ? 219 Lines ? 13595 Branches ? 0 ======================================= Hits ? 11493 Misses ? 1734 Partials ? 368 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 3 months ago

/lgtm /approve /cherry-pick release-1.15

knative-prow-robot commented 3 months ago

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to [this](https://github.com/knative/serving/pull/15420#issuecomment-2258187172): >/lgtm >/approve >/cherry-pick release-1.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving/blob/main/OWNERS)~~ [dprotaso,skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow-robot commented 3 months ago

@dprotaso: new pull request created: #15424

In response to [this](https://github.com/knative/serving/pull/15420#issuecomment-2258187172): >/lgtm >/approve >/cherry-pick release-1.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.