search

knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.57k stars 1.16k forks source link

update schema-config #15467

Closed dprotaso closed 3 months ago

dprotaso commented 3 months ago

Newer K8s API include list-type markers that break since we relax the container name requirement. We also need to drop list type markers for host aliases because we prune the entire schema

Unblocks https://github.com/knative/serving/pull/15462

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.47%. Comparing base (79dd728) to head (25bf3cb). Report is 38 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15467 +/- ## ========================================== - Coverage 84.57% 84.47% -0.10% ========================================== Files 219 219 Lines 13587 13608 +21 ========================================== + Hits 11491 11496 +5 - Misses 1728 1742 +14 - Partials 368 370 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 3 months ago

/retest

flakey e2e on kind

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/serving/blob/main/OWNERS)~~ [ReToCode,dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment