knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.57k stars 1.16k forks source link

Added the scorecard github action and its badge #15473

Open harshitasao opened 3 months ago

harshitasao commented 3 months ago

Fixes https://github.com/knative/community/issues/1592

Proposed Changes

PR to add the Scorecard GitHub Action and its badge in the README file.

Release Note

NONE
knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshitasao Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/serving/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow[bot] commented 3 months ago

Welcome @harshitasao! It looks like this is your first PR to knative/serving 🎉

knative-prow[bot] commented 3 months ago

Hi @harshitasao. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
harshitasao commented 3 months ago

cc @davidhadas

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.46%. Comparing base (c51ee6c) to head (e17210f). Report is 44 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15473 +/- ## ========================================== + Coverage 84.44% 84.46% +0.02% ========================================== Files 219 219 Lines 13608 13608 ========================================== + Hits 11491 11494 +3 + Misses 1744 1743 -1 + Partials 373 371 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

skonto commented 1 month ago

/ok-to-test

skonto commented 1 month ago

@davidhadas gentle ping

davidhadas commented 1 month ago

@harshitasao

I suggest we separate this PR into 2 parts:

First, lets add the Scorecard GitHub Action << I am ok with the suggested changed to .github (also, if you have a way to add a comment in the Scorecard indicating "this scorecard is under community evaluation" - please do so, can it be done by changing the scoreboard title?)

Then, lets resolve all pending issues with the Scorecard such as those indicated in https://github.com/knative/serving/issues/15474

Last, when the community is ok with the Scorecard, we can add the comment and badge to the community readme file.

I therefore suggest to remove the changes to the readme (and badge) from this PR and add it in a future PR when the Scorecard is community approved.