Open harshitasao opened 3 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: harshitasao Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Welcome @harshitasao! It looks like this is your first PR to knative/serving 🎉
Hi @harshitasao. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
cc @davidhadas
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.46%. Comparing base (
c51ee6c
) to head (e17210f
). Report is 44 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/ok-to-test
@davidhadas gentle ping
@harshitasao
I suggest we separate this PR into 2 parts:
First, lets add the Scorecard GitHub Action << I am ok with the suggested changed to .github (also, if you have a way to add a comment in the Scorecard indicating "this scorecard is under community evaluation" - please do so, can it be done by changing the scoreboard title?)
Then, lets resolve all pending issues with the Scorecard such as those indicated in https://github.com/knative/serving/issues/15474
Last, when the community is ok with the Scorecard, we can add the comment and badge to the community readme file.
I therefore suggest to remove the changes to the readme (and badge) from this PR and add it in a future PR when the Scorecard is community approved.
Fixes https://github.com/knative/community/issues/1592
Proposed Changes
PR to add the Scorecard GitHub Action and its badge in the README file.
Release Note