Using nodeSelector/tolerations with Serving?

[jeremyrickard]

👋 This is kind of part question/feature request!

Could Revision be extended to support using Tolerations and/or Node Selectors? I get the reason why it doesn't include the entire pod spec, but I think some additional attributes to influence scheduling could be useful. I looked through the current types and I don't see how I can do this today, but I might have missed something!

For example, I might care about where my thing gets scheduled if....

• I have a hybrid cluster with both Linux and Windows nodes. I've got some things I want to run with KNative that need to run on the windows nodes. Those nodes are tainted, so I'd need to utilize label selectors / tolerations to make that a thing.

In most cases, I probably don't care where things run because serverless...but somettimes I think there are. This change seems like it would be useful and not have a ton of impact to user experience or complexity.

I'd be interested in working on this if it's something that seems palatable. cc: @krancour

[duglin]

@mattmoor let me check....

[duglin]

@mattmoor @mpetason will take a look at it

[mattmoor]

Awesome, thanks @duglin! :party-matt:

[dprotaso]

/unassign @jeremyrickard /assign @mpetason

[calclavia]

Any updates on this issue? For example, it would be great to use KNative to schedule on only preemptive nodes on GKE.

[emaildanwilson]

Would config-features then have a flag to allow affinity/nodeSelector/etc in the podSpec or would those settings somehow get set from somewhere else as defined with a fieldRef? I'm trying to understand what the implementation would look like.

[JRBANCEL]

Would config-features then have a flag to allow affinity/nodeSelector/etc in the podSpec

Yes, this looks like the right way to do this.

[emaildanwilson]

/assign @emaildanwilson

[mpetason]

Talked to @emaildanwilson on Slack. They want to take over the issue and work on it. I'm on vacation next week so I won't be able to finish it as quickly.

[evankanderson]

/assign @whaught

It sounds like Weston might be the right person to do an initial pass and then find someone else with approver if he doesn't have it by then.

[evankanderson]

/unassign whaught

Whoops, this is the issue, not the PR.

[rccrdpccl]

Glad to see this landing to knative-serving. However, since this did not look like it was going to be implemented, we have been implementing it through annotations, one CRD and a webhook, greatly simplifying the definition from the user perspective https://github.com/softonic/node-policy-webhook @sumowrestler @calclavia

[sniperking1234]

When will this feature be available?

[mattmoor]

in 0.17, which cuts a week from tomorrow.