search

knative / serving

Kubernetes-based, scale-to-zero, request-driven compute
https://knative.dev/docs/serving/
Apache License 2.0
5.56k stars 1.16k forks source link

Need E2E test for egress traffic #3426

Closed ZhiminXiang closed 5 years ago

ZhiminXiang commented 5 years ago

In what area(s)?

/area networking /area test-and-release

Describe the feature

We need an E2E test to make sure egress traffic work, especially when using Istio 1.1 which allows egress traffic by default.

We could reuse httpproxy, and configure it to send requests to external webside (e.g. www.httpbin.org).

tcnghia commented 5 years ago

/assign tzununbekov

knative-prow-robot commented 5 years ago

@tcnghia: GitHub didn't allow me to assign the following users: tzununbekov.

Note that only knative members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/knative/serving/issues/3426#issuecomment-488321547): >/assign tzununbekov Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vagababov commented 5 years ago

/reopen this constantly fails on Prow.

knative-prow-robot commented 5 years ago

@vagababov: Reopened this issue.

In response to [this](https://github.com/knative/serving/issues/3426#issuecomment-509488060): >/reopen >this constantly fails on Prow. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vagababov commented 5 years ago

https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/knative_serving/4653/pull-knative-serving-integration-tests/1148444559227752448 https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/knative_serving/4653/pull-knative-serving-integration-tests/1148424301855117313 https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/knative_serving/4560/pull-knative-serving-integration-tests/1148382274480246787 ...

ZhiminXiang commented 5 years ago

It seems not constantly fail, but a kind of flaky: https://testgrid.knative.dev/serving#continuous

markusthoemmes commented 5 years ago

@nak3 already provided a fix for it. Is it still flaky?