search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 161 forks source link

Workload Identity Enablement - Part Four #3506

Closed upodroid closed 2 years ago

upodroid commented 2 years ago

Part of knative/infra#99

This PR does the following:

/cc @kvmware

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
krsna-m commented 2 years ago

Whats up with all the vendor files being removed?

upodroid commented 2 years ago

I need to bump some deps and it is a bit trickier than expected.

upodroid commented 2 years ago

This should be good now.

  1. Diffs in prow/jobs/* is caused by https://github.com/istio/test-infra/pull/4241 a nice change by istio
  2. This PR should reduce the vendor changes for knative/test-infra#3456
  3. Changed configgen to use root go.mod
upodroid commented 2 years ago

/retest unit-tests_test-infra_main

knative-prow[bot] commented 2 years ago

@upodroid: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/knative/test-infra/pull/3506#issuecomment-1232119546): >/retest unit-tests_test-infra_main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
upodroid commented 2 years ago

/test unit-tests_test-infra_main

krsna-m commented 2 years ago

We might have to discuss this one over video chat. +1mil changes and -14k is something that does not make me feel to easy. I like more removal than adds :P

krsna-m commented 2 years ago

CC @cardil for go expertise

upodroid commented 2 years ago

ok, lets talk about it at the productivity meeting. It is mostly vendor/* changes

krsna-m commented 2 years ago

Whatever is pulling in +1mil changes in vendor files we don't need imo

upodroid commented 2 years ago

PR is ready to merged

krsna-m commented 2 years ago

/lgtm thanks!

upodroid commented 2 years ago

you need to redo your last comment and put thanks on a separate line

krsna-m commented 2 years ago

/lgtm

knative-prow[bot] commented 2 years ago

@upodroid: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/knative/test-infra/pull/3506): >Part of knative/infra#99 > >This PR does the following: >- Fixes a bug from knative/test-infra#3503, a prowjob was expecting something there so I pointed it to the new file. >- Removed service account keys from all test-infra jobs >- One job didn't even need access to Google Cloud at all. > >/cc @kvmware Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.