search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 161 forks source link

Bump Deps Manually #3509

Closed upodroid closed 2 years ago

upodroid commented 2 years ago

Makes reviewing much easier #3456

/cc @dprotaso @kvmware

cardil commented 2 years ago

Instead of deleting those go.mod files, we could add go.work as I've done in https://github.com/knative/test-infra/pull/3510

upodroid commented 2 years ago

Can I get lgtm?

upodroid commented 2 years ago

/cc @cardil

upodroid commented 2 years ago

@dprotaso can i get this merged please?

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [cardil,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow-robot commented 2 years ago

@upodroid: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dprotaso commented 2 years ago

no longer needed