search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 162 forks source link

Create signing identities for `cosign` #3516

Closed upodroid closed 2 years ago

upodroid commented 2 years ago

This PR creates two service accounts:

I will be using Keyless Signing with cosign to sign our images and binaries with these principals.

Also fixing a typo in a k8s manifest.

/cc @kvmware

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
krsna-m commented 2 years ago

Think we should wait till we get some consensuses on https://github.com/knative/hack/pull/198 before moving forward.

upodroid commented 2 years ago

This change implements Adolfo's approach in https://github.com/knative/hack/pull/198 which I'm going forward with.

krsna-m commented 2 years ago

/lgtm /hold

upodroid commented 2 years ago

/hold cancel

Infra is up