search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 161 forks source link

Stop running docs presubmit tests #3517

Closed psschwei closed 2 years ago

psschwei commented 2 years ago

Signed-off-by: Paul S. Schweigert paul@paulschweigert.com

What this PR does, why we need it:

The unit / build / continuous tests for the docs repo aren't doing meaningful work (they test the code samples, not the main docs site), and with the recent hack update to support multi-module projects (https://github.com/knative/hack/pull/205), the build tests are actually failing.

Given that these tests are basically noise, we should stop running them (see discussion in slack thread here).

For DUX signoff: /assign @abrennan89 @snneji

For Prow update (I dropped the docs config file and regenerated the config, not sure if I should've kept the file and just deleted the jobs): /assign @kvmware @upodroid

upodroid commented 2 years ago

+1 from me

Leaving LGTM to DUX leads

abrennan89 commented 2 years ago

/lgtm /approve

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [psschwei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow[bot] commented 2 years ago

@psschwei: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/knative/test-infra/pull/3517): >Signed-off-by: Paul S. Schweigert > > >**What this PR does, why we need it**: > >The unit / build / continuous tests for the docs repo aren't doing meaningful work (they test the code samples, not the main docs site), and with the recent hack update to support multi-module projects (https://github.com/knative/hack/pull/205), the build tests are actually failing. > >Given that these tests are basically noise, we should stop running them (see discussion in slack thread [here](https://knative.slack.com/archives/C9CV04DNJ/p1662554973989079)). > >For DUX signoff: >/assign @abrennan89 @snneji > >For Prow update (I dropped the docs config file and regenerated the config, not sure if I should've kept the file and just deleted the jobs): >/assign @kvmware @upodroid > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.