knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 161 forks source link

Process stale issues/PRs via Prow #3532

Closed upodroid closed 2 years ago

upodroid commented 2 years ago

This PR implements prow jobs that replace the stale action we propagate to every repo. https://github.com/knative-sandbox/knobots/blob/main/workflow-templates/knative-stale.yaml

Doing it in Prow is much simpler and supports repo exclusions, not-as-planned closure.

Copied from k8s stale bot config https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-contribex-k8s-triage-robot.yaml but we go straight from stale to closed instead of stale => rotten => closed.

/cc @dprotaso

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
krsna-m commented 2 years ago

/lgtm

knative-prow[bot] commented 2 years ago

@upodroid: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/knative/test-infra/pull/3532): >This PR implements prow jobs that replace the stale action we propagate to every repo. >https://github.com/knative-sandbox/knobots/blob/main/workflow-templates/knative-stale.yaml > >Doing it in Prow is much simpler and supports repo exclusions, not-as-planned closure. > >Copied from k8s stale bot config https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-contribex-k8s-triage-robot.yaml but we go straight from stale to closed instead of stale => rotten => closed. > > >/cc @dprotaso Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
upodroid commented 2 years ago

We need to stop propagating https://github.com/knative/test-infra/blob/main/.github/workflows/knative-stale.yaml to every repo.

Opening a PR for that soon