search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 162 forks source link

Fix release process for eventing-kafka-broker #3587

Closed aliok closed 1 year ago

aliok commented 1 year ago

Which issue(s) this PR fixes:
Fixes #

aliok commented 1 year ago

I am not sure how prow/jobs_config/knative-sandbox/eventing-kafka-broker-release-1.8.yaml is created. If it is a copy paste of 1.7 and manually changing things, then we should be good for 1.9. If that file is generated, I should modify the source.

@pierDipi maybe you know

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow[bot] commented 1 year ago

@aliok: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/knative/test-infra/pull/3587): >**Which issue(s) this PR fixes**:
>Fixes # > > > > >- Fix release process for eventing-kafka-broker >- Add missing env var for the release process >- That env var is not really needed for the release itself, but it is used in the tests that are ran just before the release > > > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.