search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 162 forks source link

Allow jobs to be cancelled in the UI + run only one prowjob at a time for nightly/release jobs #3593

Closed upodroid closed 1 year ago

upodroid commented 1 year ago

This change allows:

/cc @kvmware

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
krsna-m commented 1 year ago

/lgtm i think the gofmt errors are from files that were not changed

upodroid commented 1 year ago

/override goimports

knative-prow[bot] commented 1 year ago

@upodroid: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/knative/test-infra/pull/3593#issuecomment-1305507713): >/override goimports Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
upodroid commented 1 year ago

/override "style / Auto-format and Check (gofmt)" "style / Auto-format and Check (goimports)"

knative-prow[bot] commented 1 year ago

@upodroid: Overrode contexts on behalf of upodroid: style / Auto-format and Check (gofmt), style / Auto-format and Check (goimports)

In response to [this](https://github.com/knative/test-infra/pull/3593#issuecomment-1305508495): >/override "style / Auto-format and Check (gofmt)" "style / Auto-format and Check (goimports)" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow[bot] commented 1 year ago

@upodroid: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/knative/test-infra/pull/3593): >This change allows: >- Prowjobs can now be cancelled from the web browser without the need to login to the cluster. https://kubernetes.slack.com/archives/CDECRSC5U/p1666217793138119 >- Various teams listed here https://github.com/knative/test-infra/blob/main/prow/config.yaml#L140 can cancel and rerun jobs. >- I have set max_concurrency for all release/nightly jobs to 1 to avoid multiple concurrent runs. > >/cc @kvmware > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.