search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 162 forks source link

:bug: The `files.ReadLines` func properly reads files #3604

Closed cardil closed 1 year ago

cardil commented 1 year ago

Which issue(s) this PR fixes:
Fixes #3603

This PR retains speed of tag lookup, by skipping the rest of the file, if some tags are found.

cardil commented 1 year ago

/cc @dprotaso

cardil commented 1 year ago

/cc @kvmware /cc @upodroid

cardil commented 1 year ago

The format failures are not related, AFAIK

krsna-m commented 1 year ago

Yep the code-styler is extra zealous and suggesting on unmodified files.

knative-prow[bot] commented 1 year ago

@upodroid: Overrode contexts on behalf of upodroid: style / Auto-format and Check (gofmt), style / Auto-format and Check (goimports)

In response to [this](https://github.com/knative/test-infra/pull/3604#pullrequestreview-1170280490): >LGTM > >/override "style / Auto-format and Check (gofmt)" "style / Auto-format and Check (goimports)" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [cardil,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment