knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 162 forks source link

:bug: Use the GKE production API instead of beta #3623

Closed cardil closed 1 year ago

cardil commented 1 year ago

Which issue(s) this PR fixes:
Fixes https://github.com/knative-sandbox/kn-plugin-event/issues/242

What this PR does, why we need it:

This PR uses the default of production GKE API instead of beta.

cardil commented 1 year ago

/assign @dprotaso /assign @upodroid /assign @kvmware /cc @mgencur

dprotaso commented 1 year ago

/lgtm /approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [cardil,dprotaso,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
upodroid commented 1 year ago

btw, there is no functional difference between GA and beta APIs for GA features. The underlying feature is GA so it shouldn't be causing problems.

Have you read this guide from Google? https://cloud.google.com/kubernetes-engine/docs/how-to/nodelocal-dns-cache#known_issues

cardil commented 1 year ago

@upodroid See https://github.com/knative-sandbox/kn-plugin-event/issues/242#issuecomment-1322745383 and Slack thread: https://knative.slack.com/archives/CA9RHBGJX/p1668770983220909

cardil commented 1 year ago

Fixes https://github.com/knative-sandbox/kn-plugin-event/issues/242