search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 162 forks source link

Files needed for deployment of influxdb and grafana used by perf tests #3631

Closed nader-ziada closed 1 year ago

nader-ziada commented 1 year ago

Files needed for deployment of influxdb and grafana used by perf tests dashboard

knative-prow[bot] commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

krsna-m commented 1 year ago

@nader-ziada Is there anything more you want to add to this PR or can we remove draft and push it through? @upodroid / @nader-ziada Shouldn't this DNS entry point to something on perf.knative.DEV or am i reading that wrong?

nader-ziada commented 1 year ago

I wasn't sure where these files belong on the test-infra repo folder structure

@upodroid / @nader-ziada Shouldn't this DNS entry point to something on perf.knative.com or am i reading that wrong?

can you explain more? :D

krsna-m commented 1 year ago

I am not seeing anything at perf.knative.dev other than an error.

nader-ziada commented 1 year ago

I am not seeing anything at perf.knative.dev other than an error.

I think its because the certificate is not set up properly, will look into it. I'm seeing ERR_SSL_PROTOCOL_ERROR

krsna-m commented 1 year ago

yep same on my side. I will look over changes and @upodroid or I will get you some guidance where to put the files so we can land this. Thanks

upodroid commented 1 year ago

Can you put the kubernetes manifests under this folder please?

https://github.com/knative/test-infra/tree/main/infra/k8s/shared

krsna-m commented 1 year ago

Also, please remove the draft status of the PR since it looks like you are good to go?

krsna-m commented 1 year ago

/lgtm

dprotaso commented 1 year ago

@nader-ziada does this change also fix the SSL issues?

krsna-m commented 1 year ago

@upodroid Wanna give approve if looks good to you?

nader-ziada commented 1 year ago

@nader-ziada does this change also fix the SSL issues?

no I haven't looked at this issue yet

upodroid commented 1 year ago

We spoke about this issue at the Productivity Meeting. The influxdb installation is broken and no one of the credentials in the secret work.

You can also use grafana.knative.dev instance to host your dashboards and add the datasource to it.

nader-ziada commented 1 year ago

We spoke about this issue at the Productivity Meeting. The influxdb installation is broken and no one of the credentials in the secret work.

You can also use grafana.knative.dev instance to host your dashboards and add the datasource to it.

broken how?

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nader-ziada, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment