search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 162 forks source link

skips unknown contexts for async component #3633

Closed AngeloDanducci closed 1 year ago

AngeloDanducci commented 1 year ago

Which issue(s) this PR fixes:
Fixes https://github.com/knative-sandbox/async-component/issues/121

Appears there's some difference in how network activity is handled between the two, this should sidestep the failure of the duplicate test run by GH actions.

krsna-m commented 1 year ago

/lgtm

krsna-m commented 1 year ago

/approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AngeloDanducci, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [kvmware] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow[bot] commented 1 year ago

@AngeloDanducci: Updated the config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/knative/test-infra/pull/3633): >**Which issue(s) this PR fixes**:
>Fixes https://github.com/knative-sandbox/async-component/issues/121 > >Appears there's some difference in how network activity is handled between the two, this should sidestep the failure of the duplicate test run by GH actions. > > > > > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.