search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 162 forks source link

Remove unsupported 1.5 relase #3640

Closed krsna-m closed 1 year ago

krsna-m commented 1 year ago

Which issue(s) this PR fixes:
Fixes https://github.com/knative/test-infra/issues/3638

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [kvmware] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
krsna-m commented 1 year ago

/cc @dprotaso @cardil

dprotaso commented 1 year ago

I see there was a job that did this - https://github.com/knative/test-infra/pull/3585

I wonder why it's not pruning 1.5 for EOL - unless it's hard coded to support the last 4 releases - which we're in a transition to support the last two

dprotaso commented 1 year ago

Would merging this PR trigger the automation to create a new PR adding the manifests back?

krsna-m commented 1 year ago

Hmm I just naively read the Readme that says Used to update Prow configs when new releases appear in Knative repos, but I do see a releaseToRemove function and a maxReleaseBranches which I will update. Thanks for pointing that out.