Closed upodroid closed 1 year ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: upodroid
The full list of commands accepted by this bot can be found here.
The pull request process is described here
You have some no newline issues else lgtm
/hold
I had to revert my change earlier. Prow unfortunately doesn't understand different contexts properly. It assumes all users have cluster-admin which isn't good.
First order of business is extending config-bootstrapper to use a context.
A quick fix would be to load a kubeconfig with just only the config-bootstrapper context.
Also, it is 7 days till the release day so I don't really want to make some changes this week and cause testgrid to show extra flakes from infra changes/snafu
/hold cancel
I created a dedicated secret for it with just a single context. I will experiment with the contexts after the release is done.
/lgtm
/cc @dprotaso @kvmware
1st commit fixes the e2e serving errors @dprotaso mentioned 2nd commit fixes the config-bootstrapper errors. Basically, it was pointing to the old prow control plane cluster which I deleted this month.
Contents of the kubeconfig:
I'm working with sig-testing at Kubernetes on getting rid of the bearer tokens and using the gke auth plugins.
https://github.com/kubernetes/test-infra/issues/28142