knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 163 forks source link

Fix config-bootstrapper and test-runner RBAC #3672

Closed upodroid closed 1 year ago

upodroid commented 1 year ago

/cc @dprotaso @kvmware

1st commit fixes the e2e serving errors @dprotaso mentioned 2nd commit fixes the config-bootstrapper errors. Basically, it was pointing to the old prow control plane cluster which I deleted this month.

Contents of the kubeconfig:

 REDACTED  C02CW0CDP3YY  ~  $  kg secret -n test-pods prow-kubeconfig -o yaml | yq '.data."kubeconfig.yaml"' | base64 -d | yq .contexts
- context:
    cluster: prow-build
    user: prow-build
  name: prow-build
- context:
    cluster: prow-trusted
    user: prow-trusted
  name: prow-trusted
- context:
    cluster: prow-control-plane
    user: prow-control-plane
  name: prow-control-plane

I'm working with sig-testing at Kubernetes on getting rid of the bearer tokens and using the gke auth plugins.

https://github.com/kubernetes/test-infra/issues/28142

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
krsna-m commented 1 year ago

You have some no newline issues else lgtm

upodroid commented 1 year ago

/hold

I had to revert my change earlier. Prow unfortunately doesn't understand different contexts properly. It assumes all users have cluster-admin which isn't good.

First order of business is extending config-bootstrapper to use a context.

upodroid commented 1 year ago

A quick fix would be to load a kubeconfig with just only the config-bootstrapper context.

upodroid commented 1 year ago

Also, it is 7 days till the release day so I don't really want to make some changes this week and cause testgrid to show extra flakes from infra changes/snafu

upodroid commented 1 year ago

/hold cancel

I created a dedicated secret for it with just a single context. I will experiment with the contexts after the release is done.

krsna-m commented 1 year ago

/lgtm