search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 163 forks source link

Revert "add new job to run internal encryption tests for Contour (#36… #3694

Closed KauzClay closed 1 year ago

KauzClay commented 1 year ago

This reverts commit 71d847859a56204be4c81e380f8b2b5f6effd4dc.

What this PR does, why we need it:
Based on feedback here: https://github.com/knative/serving/pull/13536

There is a different approach that will get much better test coverage than this test job.

krsna-m commented 1 year ago

/lgtm

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KauzClay, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [psschwei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow[bot] commented 1 year ago

@KauzClay: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/knative/test-infra/pull/3694): >This reverts commit 71d847859a56204be4c81e380f8b2b5f6effd4dc. > > >**What this PR does, why we need it**:
>Based on feedback here: https://github.com/knative/serving/pull/13536 > >There is a different approach that will get much better test coverage than this test job. > > > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.