knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 163 forks source link

:bug: Buoy will not float current project #3696

Closed cardil closed 1 year ago

cardil commented 1 year ago

Which issue(s) this PR fixes:

Fixes https://github.com/knative/hack/issues/264

/lint

krsna-m commented 1 year ago

LGTM, but someone else might wanna look over it before.

cardil commented 1 year ago

/hold

I'd like to confirm on kn-plugin-event...

cardil commented 1 year ago

Confirmed to work as intended on kn-plugin-event.

Current latest buoy

$ cd ~/git/kn-plugin-event/build
$ go run knative.dev/test-infra/buoy@latest float \
  --domain knative.dev \
  --release 1.9 \
  --module-release 0.36 go.mod
knative.dev/kn-plugin-event@main
$ cd ..
$ go run knative.dev/test-infra/buoy@latest float \
  --domain knative.dev \
  --release 1.9 \
  --module-release 0.36 go.mod
knative.dev/client-pkg@release-1.9
knative.dev/eventing@v0.36.1
knative.dev/hack@release-1.9
knative.dev/pkg@release-1.9
knative.dev/reconciler-test@release-1.9
knative.dev/serving@v0.36.0

NOTE: Notice the buoy running in build/ dir prints the knative.dev/kn-plugin-event@main, which is wrong.

Buoy compiled from this PR

$ go build -o ~/bin/buoy ./buoy
$ cd ~/git/kn-plugin-event/build
$ ~/bin/buoy float \
  --domain knative.dev \
  --release 1.9 \
  --module-release 0.36 go.mod
$ cd ..
$ ~/bin/buoy float \
  --domain knative.dev \
  --release 1.9 \
  --module-release 0.36 go.mod                               
knative.dev/client-pkg@release-1.9
knative.dev/eventing@v0.36.1
knative.dev/hack@release-1.9
knative.dev/pkg@release-1.9
knative.dev/reconciler-test@release-1.9
knative.dev/serving@v0.36.0

/hold cancel

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [cardil,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment