Closed cardil closed 1 year ago
LGTM, but someone else might wanna look over it before.
/hold
I'd like to confirm on kn-plugin-event...
latest
buoy$ cd ~/git/kn-plugin-event/build
$ go run knative.dev/test-infra/buoy@latest float \
--domain knative.dev \
--release 1.9 \
--module-release 0.36 go.mod
knative.dev/kn-plugin-event@main
$ cd ..
$ go run knative.dev/test-infra/buoy@latest float \
--domain knative.dev \
--release 1.9 \
--module-release 0.36 go.mod
knative.dev/client-pkg@release-1.9
knative.dev/eventing@v0.36.1
knative.dev/hack@release-1.9
knative.dev/pkg@release-1.9
knative.dev/reconciler-test@release-1.9
knative.dev/serving@v0.36.0
NOTE: Notice the buoy running in build/
dir prints the knative.dev/kn-plugin-event@main
, which is wrong.
$ go build -o ~/bin/buoy ./buoy
$ cd ~/git/kn-plugin-event/build
$ ~/bin/buoy float \
--domain knative.dev \
--release 1.9 \
--module-release 0.36 go.mod
$ cd ..
$ ~/bin/buoy float \
--domain knative.dev \
--release 1.9 \
--module-release 0.36 go.mod
knative.dev/client-pkg@release-1.9
knative.dev/eventing@v0.36.1
knative.dev/hack@release-1.9
knative.dev/pkg@release-1.9
knative.dev/reconciler-test@release-1.9
knative.dev/serving@v0.36.0
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cardil, upodroid
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Which issue(s) this PR fixes:
Fixes https://github.com/knative/hack/issues/264
/lint