Closed evankanderson closed 1 year ago
@cardil looks good to you?
I think Chris is only on mobile this week, according to another message on Slack.
This is anti-urgent, so I think it can wait.
I simplified the code one more time, removing Selector
as an exported type in favor of returning an anonymous function which captures the "module under prefix but not in my current workspace" requirement.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cardil, evankanderson
The full list of commands accepted by this bot can be found here.
The pull request process is described here
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cardil, evankanderson
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I decided to follow up on my comments on #3696 for filtering Buoy modules.
I figured writing the refactor was the easiest way to communicate my ideas; this removes the need for
MatcherFunc
and simplifies the calling inferface forModule
andModules
in a few places. I'm considering replacingSelector
with 'In()and
Except, but I'm not sure it is a substantial improvement. (
Excludesis only used in one place, and
In(string...)and
Except(Matcher, Matcher)` would cover the same cases.)/assign @cardil