search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 161 forks source link

EasyCLA and Tide (from Slack) #3708

Closed krsna-m closed 1 year ago

krsna-m commented 1 year ago

From @aliok :

There's an issue with EasyCLA and Prow.
A PR can be put in the merge queue w/o the CLA. But, it won't be merged by Prow.
And, since it is a FIFO queue, that PR will block every other valid PR for a repository.
It was happening before (https://cloud-native.slack.com/archives/C04LY4M2G49/p1675237966468319) and I saw it happened again now.
https://github.com/knative/docs/pull/5381 is approved and has lgtm, but CLA authorization is missing.
If you check Tide (https://prow.knative.dev/tide), you can see it is in the merge queue and it waits there forever.
https://github.com/knative/docs/pull/5402 for example is all good (approved, CLA authorized, lgtm'ed) and is also in the merge queue. It just sits there forever.
For workaround we can add a /hold to 5381 and 5402 will be unblocked.

#5381 Fixes a typo in docs #5402 Update the advanced istio installation docs

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.