knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 161 forks source link

Reviewers not being assigned by prow #3719

Closed dprotaso closed 1 year ago

dprotaso commented 1 year ago

I created a PR and for some reason reviewers weren't added by Prow

https://github.com/knative-sandbox/net-istio/pull/1061

But I have reviewers in the OWNERS file

https://github.com/knative-sandbox/net-istio/blob/f055c175caad377e3187defbc4200f36e6e2ab6a/OWNERS#L9-L11

dprotaso commented 1 year ago

/assign @upodroid @kvmware

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

dprotaso commented 1 year ago

I'm gonna close this out - I think it's working as expected now

dprotaso commented 1 year ago

This doesn't seem to be working

https://github.com/knative-sandbox/net-istio/pull/1117 https://github.com/knative-sandbox/net-certmanager/pull/540

/unassign @upodroid

@kvmware can you look into this

krsna-m commented 1 year ago

To confirm you are not seeing this only on knative-sandbox or also with knative? I am seeing as recently as 5mins ago this working for knative at least.

dprotaso commented 1 year ago

I'm noticing it's not working in knative-sandbox