search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 161 forks source link

Revert "Process stale issues/PRs via Prow (#3532)" #3730

Closed krsna-m closed 1 year ago

krsna-m commented 1 year ago

previous pr: https://github.com/knative/test-infra/pull/3722

This reverts commit 3fe80a667adf66613eb8f95ccf627537f7c7844d.

What this PR does, why we need it:
There already exists a knative/actions stale action. As already discussed with the community a few times now, we are trying to minimize prow usage - https://github.com/knative/test-infra/issues/3479

dprotaso commented 1 year ago

Approving so the two bots don't fight each other

/lgtm /approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [dprotaso,kvmware] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow[bot] commented 1 year ago

@kvmware: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/knative/test-infra/pull/3730): >previous pr: https://github.com/knative/test-infra/pull/3722 > >This reverts commit 3fe80a667adf66613eb8f95ccf627537f7c7844d. > >**What this PR does, why we need it**:
>There already exists a knative/actions stale action. As already discussed with the community a few times now, we are trying to minimize prow usage - https://github.com/knative/test-infra/issues/3479 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
upodroid commented 1 year ago

Let's have a longer discussion about this. +1 for revert

krsna-m commented 1 year ago

@upodroid sure thing!