Closed dprotaso closed 1 year ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dprotaso
The full list of commands accepted by this bot can be found here.
The pull request process is described here
You have successfully added a new CodeQL configuration .github/workflows/knative-security.yaml:analyze-codeql
. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.
/retest
/test unit-tests_test-infra_main
Do you have a link to the unwanted bump? I see https://github.com/knative/test-infra/commit/1305d234c0e41dad2db9539d7a8ef24791a95161 this is most recent 1.19->1.20
initial behavior was to have a latest stable go version and manually bump older versions https://github.com/knative/test-infra/pull/3746/files#diff-3a809bc2ddb42dd8cd4627d729d61452cc1ed660a8d82ae02476cf740e7740faR242
https://github.com/knative/test-infra/commit/1305d234c0e41dad2db9539d7a8ef24791a95161 this broke that assumption.
I see the logic you want to implement though.
/lgtm
Dependabot bumped our 1.19 image to 1.20 which is something we don't want.
I'm hoping this change will mean we'll only bump respective patches