search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 164 forks source link

go mod tidy to unblock release-jobs-syncer #3811

Closed krsna-m closed 1 year ago

krsna-m commented 1 year ago

Manually running dependabots bumps broke release-jobs-syncer https://prow.knative.dev/?job=ci-knative-prow-jobs-syncer.

Should Fixes: https://github.com/knative/test-infra/issues/3728

krsna-m commented 1 year ago

@upodroid We should put something into place so this does not happen in future with dpendabot bumps. cc @cardil (I thought we had a check against this?)

dprotaso commented 1 year ago

Surprised there wasn't any notification about this job failure

/lgtm /approve

krsna-m commented 1 year ago

@upodroid What is the latest with job fail reports? We have not been getting them and I know it had to do with billing or something, but didnt we get that solved and migrated completely lately?

upodroid commented 1 year ago

The Slack config was changed and the webhooks might be buggy. i'll need to test it.

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, kvmware, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [dprotaso,kvmware,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment