search

knative / test-infra

Test infrastructure for the Knative project
Apache License 2.0
82 stars 164 forks source link

Add env to knative/hack unit tests #3824

Closed upodroid closed 1 year ago

upodroid commented 1 year ago

/cc @kvmware @cardil

This PR should fix the unbound variable error breaking the units tests in https://github.com/knative/hack/pull/230

I also ran shfmt on the run_job.sh script.

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/test-infra/blob/main/OWNERS)~~ [upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
krsna-m commented 1 year ago

/lgtm

knative-prow[bot] commented 1 year ago

@upodroid: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/knative/test-infra/pull/3824): >/cc @kvmware @cardil > >This PR should fix the unbound variable error breaking the units tests in https://github.com/knative/hack/pull/230 > >I also ran shfmt on the run_job.sh script. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.